fix: Adding ipv6 check on the node init function#10
Open
MitchLewis930 wants to merge 1 commit intopr_050_beforefrom
Open
fix: Adding ipv6 check on the node init function#10MitchLewis930 wants to merge 1 commit intopr_050_beforefrom
MitchLewis930 wants to merge 1 commit intopr_050_beforefrom
Conversation
Cilium pods on a single stack cluster were failing when ipv6 was enabled. The change would make sure that if the underlying node does not have ipv6 configuration enabled it would fail even if KPR is disabled.Earlier, if KPR is enabled, the node would not see a fatal error. Signed-off-by: Vipul Singh <singhvipul@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR_050
Note
Medium Risk
Changes daemon startup behavior by introducing a new hard failure path when IPv6 is enabled, which may cause previously-starting misconfigured nodes to now exit early.
Overview
Adds a startup validation in
k8s.WaitForNodeInformationto fail fast when IPv6 is enabled but the Kubernetes-reported node has no IPv6 address (GetNodeIP(true)returnsnil).On this condition, the daemon now logs an explicit error and returns a descriptive
fmt.Errorf, preventing later initialization with incomplete IPv6 node addressing.Written by Cursor Bugbot for commit 2fc52eb. This will update automatically on new commits. Configure here.