aws/ec2: properly paginate DescribeNetworkInterfaces results#6
Open
MitchLewis930 wants to merge 1 commit intopr_046_beforefrom
Open
aws/ec2: properly paginate DescribeNetworkInterfaces results#6MitchLewis930 wants to merge 1 commit intopr_046_beforefrom
MitchLewis930 wants to merge 1 commit intopr_046_beforefrom
Conversation
Signed-off-by: Anton Ippolitov <anton.ippolitov@datadoghq.com>
There was a problem hiding this comment.
Pull request overview
This PR improves the pagination handling for AWS EC2 DescribeNetworkInterfaces API calls by introducing an explicit maximum results limit per API call.
Changes:
- Added a new constant
ENIMaxResultsPerApiCallset to 1000 to control the number of ENI objects fetched per API call - Applied the MaxResults parameter to three DescribeNetworkInterfaces API invocations to enable proper pagination
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/defaults/defaults.go | Defines the new ENIMaxResultsPerApiCall constant with a value of 1000 |
| pkg/aws/ec2/ec2.go | Adds MaxResults parameter to three DescribeNetworkInterfaces API calls using the new constant |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR_046