operator: fix errors/warnings metric.

[MitchLewis930]

PR_048

[Copilot]

Pull request overview

This PR refactors the errors/warnings metric initialization to support proper registration in both the agent and operator contexts. The changes extract the metric creation into a shared helper function and introduce explicit initialization and flushing mechanisms for the operator.

Changes:

• Extracted errors/warnings metric creation into a shared newErrorsWarningsMetric() helper function
• Added InitOperatorMetrics() function to initialize operator-specific metrics
• Introduced FlushLoggingMetrics() to encapsulate the metrics flushing logic using sync.Once

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
pkg/metrics/metrics.go	Refactored ErrorsWarnings metric to use new helper function and added InitOperatorMetrics()
pkg/metrics/logging_hook.go	Added FlushLoggingMetrics() function with sync.Once pattern for thread-safe flushing
pkg/metrics/cell.go	Updated to use new FlushLoggingMetrics() function
operator/metrics/metrics.go	Added operator metric initialization and flushing calls

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The variable flushMetrics should be named with a noun rather than a verb. Consider renaming it to flushMetricsOnce to better reflect that it's a sync.Once object and follow Go naming conventions.

Suggested change

	flushMetrics = sync.Once{}
	)
	// FlushLoggingMetrics will cause all logging hook metrics accumulated prior
	// to the errors_warnings metrics being registered with the Prometheus collector
	// to be incremented to their respective errors_warnings metrics tuple.
	func FlushLoggingMetrics() {
	flushMetrics.Do(func() {
	flushMetricsOnce = sync.Once{}
	)
	// FlushLoggingMetrics will cause all logging hook metrics accumulated prior
	// to the errors_warnings metrics being registered with the Prometheus collector
	// to be incremented to their respective errors_warnings metrics tuple.
	func FlushLoggingMetrics() {
	flushMetricsOnce.Do(func() {