Mark empty _terms_enum results due to DLS as incomplete (#91720)#2
Open
MitchLewis930 wants to merge 1 commit intopr_012_beforefrom
Open
Mark empty _terms_enum results due to DLS as incomplete (#91720)#2MitchLewis930 wants to merge 1 commit intopr_012_beforefrom
_terms_enum results due to DLS as incomplete (#91720)#2MitchLewis930 wants to merge 1 commit intopr_012_beforefrom
Conversation
) Today `_terms_enum` returns empty results for indices with document level security. Elasticsearch should return some hint in case the user hits empty results due to DLS limitation so the caller (ie. Kibana) can fall back to other strategies or notify the user with some appropriate error message. This changes the behaviour of the NodeTransportHandler so that it returns a NodeTermsEnumResponse with an error indication. The resulting API response will flag the enum as "incomplete" and list the error in the shard errors section. Clients can choose to react to this in the appropriate way. Closes elastic#88321
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| false | ||
| ) | ||
| ); | ||
| } |
There was a problem hiding this comment.
Missing return after calling listener causes duplicate responses
High Severity
When canAccess returns false, listener.onResponse() is called but the method continues execution without returning. The loop proceeds to check additional shards and eventually calls listener.onResponse() again (at line 737 if no shards remain, or via dataNodeOperation). This violates the ActionListener contract that it be invoked exactly once, likely causing response-already-sent errors or undefined behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR_012
Note
Medium Risk
Changes the
_terms_enumsecurity/response semantics and shard failure reporting, which could affect clients relying on empty results; covered by updated integration tests.Overview
_terms_enumnow reports incomplete results when a shard is skipped due to DLS/FLS restrictions, returning an explicit shard failure reason instead of silently yielding an empty term list.YAML REST tests are updated to assert
complete: false, shard failure counts, and the new error message for DLS-restricted users/API keys, while confirming FLS-only restrictions still returncomplete: truewith zero failures.Written by Cursor Bugbot for commit 635a4fe. This will update automatically on new commits. Configure here.