Add explicit @classmethod decorators to Pydantic validator methods #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validator methods using
clsparameter lacked explicit@classmethoddecorators, violating Python naming conventions that methods withclsshould be classmethods.Changes
unified_validatordecorator to extract the underlying function from@classmethodwrappers when present@classmethoddecorators to all validator methods:ensure_keys,validate_addr,validate_comm_error_ctr,validate_ventilation_fields,extract_sensor_values,set_optional_enumExample
Before:
After:
The validators receive the class (not instance) from Pydantic's
@root_validator/@model_validator, making@classmethodsemantically correct.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.