Issue32 #33
Open
Issue32 #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Took out reauthenticate variable because it wasn't being used.
This reverts commit 5d90e54.
…ringModelsCommand
- GetContactScoresCommand#contactId should be a Long, not Integer
- com.silverpop.api.client.converters.ApiDateConverter works only with one fixed format, fails for others
- typo in the annotation of GetContactScoresModel#scoreComponents
- GetContactScoresModelScoreComponent#value could be a String, not only an Integer
- the annotation value for GetScoringModelsModel#scoreComponents should be SCORE_COMPONENT_TYPES, not SCORE_COMPONENTS
- the annotation value for GetScoringModelsModelScoreComponent should be SCORE_COMPONENT_TYPE, not SCORE_COMPONENT
- missing annotation of GetScoringModelsModelScoreComponentValues
Contributor
|
Hi rkovarik, Can you check that this is still relevant based on the refactoring for OAuth you did? Thanks, Chris |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.