Skip to content

Conversation

@meladRaouf
Copy link
Collaborator

JIRA ticket
Will be released in: 2026.1.0

Root cause analysis (for bugfixes only)

First known affected version: Many releases ago

image

Notable changes

  • Restart face capture if the Confirmation screen shows an empty bitmap. This occurs when the system recreates the Confirmation screen (for example, after process death).

Testing guidance

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

@cla-bot cla-bot bot added the ... label Jan 31, 2026
@meladRaouf meladRaouf requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, luhmirin-s and ybourgery and removed request for a team January 31, 2026 18:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR handles face detection state loss in ConfirmationFragment to prevent crashes when the system recreates the fragment after process death. The fix detects when the face detection data is missing and triggers a recapture flow, along with adding validation to prevent empty captures from being finalized.

Changes:

  • Added null check in ConfirmationFragment to detect state loss and trigger recapture
  • Added validation in FaceCaptureViewModel.flowFinished() to prevent empty captures

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
face/capture/src/main/java/com/simprints/face/capture/screens/confirmation/ConfirmationFragment.kt Added state loss detection in onViewCreated to check for null detection/bitmap and trigger recapture
face/capture/src/main/java/com/simprints/face/capture/screens/FaceCaptureViewModel.kt Added require() validation to prevent flowFinished() from proceeding with empty format or items

@meladRaouf meladRaouf force-pushed the bugfix/face-confirmation-empty-state branch from d9f2666 to a8b338b Compare February 2, 2026 10:39
@meladRaouf meladRaouf force-pushed the bugfix/face-confirmation-empty-state branch from a8b338b to 17ab73d Compare February 2, 2026 10:46
@meladRaouf meladRaouf requested review from BurningAXE, Copilot and luhmirin-s and removed request for BurningAXE February 2, 2026 10:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2026

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@meladRaouf meladRaouf merged commit 820b14a into release/2026.1.0 Feb 2, 2026
26 checks passed
@meladRaouf meladRaouf deleted the bugfix/face-confirmation-empty-state branch February 2, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants