Correcting calls to arStrip() and pd.DataFrame.append()
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pd.DataFrame.append` is now deprecated and raises an `AttributeError`, this change proposes accumulating Series in the duplication detection process and initializing a `DataFrame()` with them at the end of the duplication loop. Also fixes misspelled `arStrip()` parameters; raises `TypeError`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pd.DataFrame.appendis deprecated and raises anAttributeError:This change proposes accumulating Series in the duplication detection process and initializing a
DataFrame()with them at the end of the duplication loop. Alternatively, it seems maintainers can opt to use_append(), however, I prefer this approach.This change also fixes misspelled parameters in the call to
arStrip():