Skip to content

Conversation

@yavorsk
Copy link
Contributor

@yavorsk yavorsk commented Jan 26, 2026

Description / Motivation

This PR is a follow-up to #2178 and addresses the following issue:

  • when assigning basePath property of NextUrl, if basePath is empty string it gets assigned as '/' instead of ''; this causes redirects to not work properly when basePath is not configured;

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate) - test redirects, with and without basePath, in both client side and server side navigation;

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Collaborator

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@illiakovalenko illiakovalenko merged commit 716101f into dev Jan 26, 2026
5 checks passed
@illiakovalenko illiakovalenko deleted the bugfix/JSS-8855 branch January 26, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants