Skip to content

Conversation

@sovdeeth
Copy link
Member

@sovdeeth sovdeeth commented Dec 10, 2025

Problem

Now that we're supporting 18 months of versions on Java 21, the test times are getting overly long since it's all a single action (7+ minutes).

Solution

This pulls from experiments done in #8254 and adds a test task (customTest) that runs tests based on provided properties rather than hardcoded values. This allows the github action parallelize-tests to create a matrix of test environments split over N actions, which then runs a subset of the total environments. Given each test takes about 60s, plus the initial build that takes 30s, this cuts runtime for 8 versions from 8:30 to 3:30 if split 3 ways, or 2:30 if split 4. I've chosen split 3 ways to not clog up the check tab too much.

Also added 1.21.1 test env for full coverage

Testing Completed

Manual confirmation of the customTest task working, plus the check tab of this pr

Supporting Information


Completes: none
Related: none
AI assistance: none

@sovdeeth sovdeeth requested review from a team as code owners December 10, 2025 18:14
@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Dec 10, 2025
@sovdeeth sovdeeth requested review from Absolutionism and UnderscoreTud and removed request for a team December 10, 2025 18:14
@sovdeeth sovdeeth added the github related Issues or Pull requests that affect the GitHub organization/repositories label Dec 10, 2025
@sovdeeth sovdeeth moved this to In Review in 2.14 Releases Dec 10, 2025
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Dec 12, 2025
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.14 Releases Dec 19, 2025
@skriptlang-automation skriptlang-automation bot added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed needs reviews A PR that needs additional reviews labels Dec 19, 2025
@github-project-automation github-project-automation bot moved this from Awaiting Merge to In Review in 2.14 Releases Dec 19, 2025
@skriptlang-automation skriptlang-automation bot removed the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Dec 19, 2025
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.14 Releases Dec 19, 2025
@skriptlang-automation skriptlang-automation bot added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Dec 19, 2025
@sovdeeth sovdeeth merged commit 24a2435 into SkriptLang:dev/feature Dec 19, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.14 Releases Dec 19, 2025
@skriptlang-automation skriptlang-automation bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. labels Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. github related Issues or Pull requests that affect the GitHub organization/repositories

Projects

Status: Done - Awaiting Release

Development

Successfully merging this pull request may close these issues.

4 participants