Skip to content

Conversation

@smhg
Copy link

@smhg smhg commented Jun 13, 2025

This bumps phpstan and its extensions to version 2.
It also:

  • Adds a composer script to run it with composer run stan.
  • Fixes some (easy) phpstan warnings.
  • Adds the current phpstan baseline to git.
  • Adds phpstan to CI.

Please squash the PR if you decide to merge this.

Tagging @SkyFoxvn

@smhg smhg force-pushed the update-dep-phpstan branch from c92c825 to fb7f480 Compare June 16, 2025 08:20
@smhg
Copy link
Author

smhg commented Jun 16, 2025

@SkyFoxvn can you please re-run CI?
I've moved static analysis (PHPStan) to it's own job to run on just 1 PHP version (currently 8.3). Propel itself does that too.

The reason PHPStan fails on 8.0.2 is that Symfony 6.0.x components are always used on that PHP version.
The CI job labels don't correctly show what actually gets installed.

Thanks!

@smhg
Copy link
Author

smhg commented Jun 17, 2025

@SkyFoxvn thanks! Can you please force a CI re-run? It looks like it somehow didn't run on your last commit.

@SkyFoxvn
Copy link
Owner

SkyFoxvn commented Jun 17, 2025

@SkyFoxvn thanks! Can you please force a CI re-run? It looks like it somehow didn't run on your last commit.

@smhg well im not sure how to start a new run for pull request(only for branches part of the repo) so i did go to actions and rerun the tests run already created for this branch still ending with error

@smhg
Copy link
Author

smhg commented Jun 17, 2025

@SkyFoxvn sorry, I missed an invalid double-declaration of "scripts" in composer.json. Feel free to approve CI. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants