expanding generic payload#6
Open
thomas-watters-skydio wants to merge 1 commit intovivian.zhou/revup/master/generic_payloadfrom
Open
expanding generic payload#6thomas-watters-skydio wants to merge 1 commit intovivian.zhou/revup/master/generic_payloadfrom
thomas-watters-skydio wants to merge 1 commit intovivian.zhou/revup/master/generic_payloadfrom
Conversation
thomas-watters-skydio
requested review from
jenke-skydio,
josh-raanan-skydio,
shane-clark-skydio and
tal-zaitsev-skydio
Author
|
This PR hopes to take an even more generic approach to attachments. |
| </enum> | ||
| <enum name="GENERIC_PAYLOAD_VALUE_TYPE"> | ||
| <description>Data type for generic payload function values.</description> | ||
| <entry value="0" name="GENERIC_PAYLOAD_VALUE_TYPE_INT32"> |
Comment on lines
+751
to
+753
| <field type="uint8_t[4]" name="value_low">Lower 32 bits of current value. For 32-bit types, this is the entire value. For 64-bit types, this is the least significant word.</field> | ||
| <field type="uint8_t[4]" name="min_low">Lower 32 bits of minimum value (for CONTINUOUS/DISCRETE types).</field> | ||
| <field type="uint8_t[4]" name="max_low">Lower 32 bits of maximum value (for CONTINUOUS/DISCRETE types).</field> |
There was a problem hiding this comment.
this will probably have the most push-back, i like the idea of being able to support 64data, but maybe we can leave this should the need arise, thankfully extension fields allow us to do that
| <field type="uint8_t" name="type" enum="GENERIC_PAYLOAD_FUNCTION_TYPE">Type of function.</field> | ||
| <field type="uint8_t" name="value_type" enum="GENERIC_PAYLOAD_VALUE_TYPE">Data type for value/min/max fields.</field> | ||
| <field type="uint8_t" name="enabled">0: Disabled, 1: Enabled</field> | ||
| <field type="uint8_t[4]" name="value_low">Lower 32 bits of current value. For 32-bit types, this is the entire value. For 64-bit types, this is the least significant word.</field> |
Author
There was a problem hiding this comment.
there is often confusion with MAV_CMDs that have a data type of float but are supposed to be interpreted as bool/int through casts, i think i having a generic "union" type, transported as bytes works better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.