Clean up retry backoff per PR #222 review#223
Open
matias-christensen-skydio wants to merge 1 commit intomainfrom
Open
Clean up retry backoff per PR #222 review#223matias-christensen-skydio wants to merge 1 commit intomainfrom
matias-christensen-skydio wants to merge 1 commit intomainfrom
Conversation
Address jerry-skydio's review comments: - Rename _retry_with_backoff to _should_retry to reflect the return value - Extract transient_statuses and retryable_graphql_errors to module-level frozenset constants, make max_retries and base_delay kwargs on graphql() - Split graphql into _graphql_once (single attempt) and graphql (retry wrapper) to reduce indentation and separate concerns
matias-christensen-skydio
force-pushed
the
retry-backoff-cleanup
branch
from
4415599 to
e00b82d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #222 addressing review comments from @jerry-skydio:
_retry_with_backoffto_should_retryto reflect that it returns a bool, not that it performs the retrytransient_statusesandretryable_graphql_errorsto module-levelfrozensetconstants (TRANSIENT_STATUSES,RETRYABLE_GRAPHQL_ERRORS); makemax_retriesandbase_delaykeyword args ongraphql()graphqlinto_graphql_once(single-attempt request logic) andgraphql(retry wrapper that catches exceptions), reducing indentation and separating concerns