Skip to content

Conversation

@VivekLumbhani
Copy link

  • Auto-detect package manager (apt/dnf/yum)
  • Map package names for different distros
  • Handle libtinfo5 installation for both Ubuntu and Fedora
  • Fix Java package names for different distros
  • Fixes Dev Setup error on Fedora #38

- Auto-detect package manager (apt/dnf/yum)
- Map package names for different distros
- Handle libtinfo5 installation for both Ubuntu and Fedora
- Fix Java package names for different distros
- Fixes Snapchat#38
@VivekLumbhani
Copy link
Author

  • Auto-detect package manager (apt/dnf/yum)
  • Map package names for different distros
  • Handle libtinfo5 installation for both Ubuntu and Fedora
  • Fix Java package names for different distros
  • Fixes Dev Setup error on Fedora #38

Description

Fixes #38

This PR adds support for Fedora/RHEL-based distributions by detecting the package manager (apt, dnf, or yum) and using the appropriate package names.

Changes Made

  • Added detectPackageManager() function to detect available package manager
  • Added package name mappings for apt, dnf, and yum
  • Updated installDependencies() to use the detected package manager

Testing Needed

⚠️ I don't have access to a Fedora system to test this.

Can someone with Fedora please test?

  • @kaicsm (original reporter) - could you test this on Fedora 38?
  • Would also appreciate testing on Ubuntu/Debian to ensure existing functionality still works

Package Name Mappings

apt (Ubuntu/Debian) dnf/yum (Fedora/RHEL)
zlib1g-dev zlib-devel
git-lfs git-lfs
watchman watchman
libfontconfig-dev fontconfig-devel
adb android-tools

## Step 10: Tag People for Testing

In the PR comments, tag the original issue reporter:

@kaicsm Hey! I've implemented a fix for Fedora support.
Could you test this branch and let me know if it works?

To test:
git clone https://github.com/VivekLumbhani/Valdi.git
cd Valdi
git checkout fix-fedora-package-manager
npm install
npm run build
valdi dev_setup

Summary of Commands

1. Fork on GitHub (use the website)

2. Clone and setup

git clone https://github.com/VivekLumbhani/Valdi.git
cd Valdi
git remote add upstream https://github.com/Snapchat/Valdi.git

3. Create branch

git checkout -b fix-fedora-package-manager

4. Make your code changes (in the source file)

5. Commit and push

git add .
git commit -m "Fix: Add support for dnf/yum package managers on Fedora/RHEL

  • Detect package manager automatically
  • Map package names for different distros
  • Fixes Dev Setup error on Fedora #38"
    git push origin fix-fedora-package-manager

6. Create PR on GitHub (use the website)

@kaicsm
Copy link

kaicsm commented Nov 14, 2025

no way we made a pull request at the same time man
#39
LOL

@VivekLumbhani
Copy link
Author

“Hi! Just checking in—whenever you get a moment, could someone please review this PR? It adds Fedora/RHEL support and fixes issue #38. Thanks for your time!”

@ThatOneCalculator
Copy link

This also conflicts with my PR #35

@VivekLumbhani
Copy link
Author

This PR currently has merge conflicts in linuxSetup.ts. It needs to be rebased or merged with main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev Setup error on Fedora

3 participants