Fix pnpm dlx --silent flag order #913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… filepath When using pnpm dlx with the --silent flag, the flag was incorrectly placed after 'dlx' in the command, causing it to be passed to the target package (e.g., @coana-tech/cli) as a positional argument. Coana's 'run' command interpreted --silent as the filepath argument instead of the actual directory. This fix moves --silent before 'dlx' so pnpm correctly interprets it: - Before: pnpm dlx --silent @coana-tech/cli run /path (incorrect) - After: pnpm --silent dlx @coana-tech/cli run /path (correct) Also adds comprehensive unit tests to prevent regression and adds .env.local to .gitignore.
billxinli
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes coana receiving
--silentas filepath argument when using pnpm dlx.Changes
--silentbeforedlxin pnpm commands.env.localto.gitignoreTest
Note
Moves
--silentbeforedlxfor pnpm execution, adds targeted unit tests, and ignores.env.local.src/utils/dlx.mts):--silentbeforedlxwhen building spawn args; adjust arg construction accordingly.npm_config_dlx_cache_max_age=0; npm uses--yes(and--silentwhen set); Yarn Berry unchanged.src/utils/dlx.test.mts):silentbehavior for pinned/unpinned versions, npm flag order, and pnpmforceenv var..env.localto.gitignore.Written by Cursor Bugbot for commit 017a220. Configure here.