Per-address option - using existing contracts #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: switching callData to memory * fix: compile errors on new contracts * done: tranche
jackdishman
force-pushed
the
per-user-config
branch
from
b580903 to
79cd6e9
Compare
cr-walker
commented
Mar 12, 2024
packages/hardhat/contracts/claim/PerAddressContinuousVestingMerkle.sol
Outdated
Show resolved
Hide resolved
cr-walker
commented
Mar 12, 2024
cr-walker
commented
Mar 12, 2024
| function claim( | ||
| uint256 index, // the beneficiary's index in the merkle root | ||
| address beneficiary, // the address that will receive tokens | ||
| uint256 totalAmount, // the total claimable by this beneficiary |
Contributor
Author
There was a problem hiding this comment.
Ditto - this doesn't seem right: need to put continuous vesting parameters (start, cliff, end) in every function that checks merkle proof since they are required to generate the leaf.
cr-walker
commented
Mar 12, 2024
packages/hardhat/contracts/claim/PerAddressContinuousVestingMerkle.sol
Outdated
Show resolved
Hide resolved
cr-walker
commented
Mar 12, 2024
cr-walker
commented
Mar 12, 2024
| function claim( | ||
| uint256 index, // the beneficiary's index in the merkle root | ||
| address beneficiary, // the address that will receive tokens | ||
| uint256 totalAmount, // the total claimable by this beneficiary |
Contributor
Author
There was a problem hiding this comment.
Add tranche params
cr-walker
commented
Mar 12, 2024
cr-walker
commented
Mar 12, 2024
Contributor
Author
cr-walker
left a comment
cr-walker
left a comment
There was a problem hiding this comment.
Missing some params in concrete contracts
Fixes to have functioning hardhat and forge tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sketch of how you can accomplish per-user vesting without having to write as much from scratch and retain the ability to handle custom tranches.