Skip to content

Conversation

@s3lph
Copy link
Member

@s3lph s3lph commented Oct 23, 2025

In our PR template we ask contributors to make sure that "the new entry is at the correct (alphabetically sorted) line", however we neither enforced this so far, nor did we provide a canonical sort order.

This PR attempts to fix this by adding a workflow that uses jq's sorting feature.

@s3lph s3lph requested a review from a team October 23, 2025 15:43
@s3lph s3lph self-assigned this Oct 23, 2025
@s3lph
Copy link
Member Author

s3lph commented Oct 23, 2025

First CI run fails as expected, and prints a diff of the proposed changes: https://github.com/SpaceApi/directory/actions/runs/18754130264/job/53501434821

After sorting the JSON document as proposed, the CI passes: https://github.com/SpaceApi/directory/actions/runs/18754311286/job/53502087007

@s3lph s3lph marked this pull request as ready for review October 23, 2025 15:57
Copy link
Contributor

@dbrgn dbrgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@s3lph s3lph merged commit 678b807 into master Oct 25, 2025
2 checks passed
@s3lph s3lph deleted the sort-action branch October 25, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants