[Breaking Changes] Thread naming refactor #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…settleVC. Everything passing!
…lso, 'already closed VC' tests occasionally fail, unclear why. Commit is passing all tests currently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been working towards renaming everything in our stack to Channel/Thread rather than LedgerChannel/VirtualChannel. We've found that it's a lot easier to both develop with and explain to users.
This PR introduces those changes to the contract. The branch is based off unit-tests so be sure to merge that first! These are breaking changes and you'll have to update the rest of your stack with corresponding naming refactor PRs if you want to use this.
One note, I've only updated the unit tests for the new naming conventions and not the old happycase/dispute tests. I think this is ok because the unit tests cover all of those cases. If needed, I can go back and edit the old tests too, what do you guys think?