Reentrancy protection #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhlsthrm
requested review from
ArjunBhuptani,
JasnaTodorovic,
LayneHaber,
alexanvl,
ameensol,
jamesyoung,
mslipper,
nginnever,
ukstv and
wolever
ukstv
reviewed
Oct 8, 2018
contracts/LedgerChannel.sol
Outdated
| require(now > Channels[_lcID].LCopenTimeout); | ||
| require(msg.sender == Channels[_lcID].partyAddresses[0], "Request not sent by channel party A"); | ||
| require(Channels[_lcID].isOpen == false, "Channel has been joined"); | ||
| require(now > Channels[_lcID].LCopenTimeout, "Channel timeout has not expire"); |
ukstv
reviewed
Oct 8, 2018
| uint256 ethbalanceA = Channels[_lcID].ethBalances[0]; | ||
| uint256 tokenbalanceA = Channels[_lcID].erc20Balances[0]; | ||
|
|
||
| Channels[_lcID].ethBalances[0] = 0; |
There was a problem hiding this comment.
Suggestion: copy ethBalanceA, tokenBalanceA, token to variables, and delete the channel before transfers. Might consume less gas.
There was a problem hiding this comment.
Suggestion is invalid till repository includes some sort of gas meter.
rhlsthrm
force-pushed
the
reentrancy-protection
branch
from
a11966d to
117b7f2
Compare
Test error msgs
…/virtual-channels into reentrancy-protection
…-channels into reentrancy-protection
…-channels into reentrancy-protection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for reentrancy fix in LCOpenTimeout.