Skip to content

Conversation

@Albinoman887
Copy link

  • vendor-bootconfig.img is now mandatory
  • having zip compression totally off ,build: Remove su inclusion #1 doesn't really make sense but ,Merge tag 'android-11.0.0_r48' of https://android.googlesource.com/pl… #2 and more important, Raven and oriole don't have a decent custom recovery just the standard lineageos one that can only adb sideload. and its VERY SLOW. so users have been flashing in fastboot d as its a simpler process and it is a good amount faster. Because of this I don't build a recovery flashable rom zip with mka bacon. I run m updatepackage it creates a zip with the partitions and android-info.txt . this allows the user to flash the build simply by rebooting to fastboot or bootloader and run fastboot update if your in bootloader it will flash boot , vendor boot and something else and then auto reboots into fastbootd to finish the rest. well don't ask me why cuz I don't know but , having tha compression 0 commit resulted in my zip being twice as large as the total size if you add up the size of all the partitions it compiled. its very strange. it also made one person not be able to flash until they updated to fastboot but they could flash all other roms. Simply reverting the commit fixes everything. I know I could just unzip and rezip every time but that worries me there is other things going wrong...

devinmoore-goog and others added 2 commits June 12, 2022 16:40
INTERNAL_VENDOR_BOOTCONFIG_TARGET is a required dependency of
target-files-package so it can be built from a clean build.

Test: rm -rf out/target/product && m target-files-package
Bug: 190329824
Change-Id: I9873aee3c9fb303d2ad245b5433d13eb76ab55f9
Reviewed-on: https://review.statixos.com/c/android_build/+/6313
Reviewed-by: Anay Wadhera <anay1018@gmail.com>
Tested-by: Anay Wadhera <anay1018@gmail.com>
GSI devices don't like this here

Signed-off-by: Matt Filetto <matt.filetto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants