Iterate through paginated API when exporting#83
Open
sfloyd-dts wants to merge 4 commits intoSparkDevNetwork:masterfrom
Open
Iterate through paginated API when exporting#83sfloyd-dts wants to merge 4 commits intoSparkDevNetwork:masterfrom
sfloyd-dts wants to merge 4 commits intoSparkDevNetwork:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, this tool makes 1 request to the API and by default it seems it does an offset of 0 and limit of 1000 which may not bring back all the results needed.
This change will iterate through the pages via the API to get all the results as needed before continuing.
This was tested on live data with around 24k records to pull.