fix: contacts list was crashing without any message when encountering a party without a contact #380
Conversation
… a party without a contact
| return result | ||
| .filter((party) => { | ||
| // Do not crash fetching the entire contacts list over one missing contact relation | ||
| if (!party.contact) { |
There was a problem hiding this comment.
with this you are masking the actual problem. A party should always have a contact which is a natural person or organization. So how was a party like this created in the first place?
There was a problem hiding this comment.
I have no explanation for that even after a second look. I just found one or more records with this state which caused the contacts overview screen to remain blank. Supabase deletes the Party which should cascade to contact, so that can't be it .
There should have been a DB constraint to protect this, but changing that is nasty now, We'd need to flip the direction of the Foreign Key, also for existing databases.
Since we are moving to IDK/EDK we should not be doing that anymore IMO, so it's either this or drop or repair the database every time this happens.
No description provided.