Skip to content

Conversation

@shoyguer
Copy link
Contributor

Fixes to layout sometimes getting miscalculated and follow focus not working.

Thanks @scgm0 for bringing this to light

@shoyguer
Copy link
Contributor Author

@scgm0 , I fixed the follow focus not working this latest commit. Can you please check if it is also working for you?
The Layout is still not fixed since I wasn't able to replicate the issue.

@scgm0
Copy link
Contributor

scgm0 commented Jan 12, 2026

图片

follow_focus still does not work.

@scgm0
Copy link
Contributor

scgm0 commented Jan 12, 2026

is still not fixed since I wasn't able to replicate the issue.

new mpr:
smoothscrollmpr_2026-01-12_13-56-00.zip

2026-01-12.13-55-42.mp4

@shoyguer
Copy link
Contributor Author

shoyguer commented Jan 16, 2026

@scgm0 , I just pushed another fix, this should make scroll method you were using also work. Though the most recommended way would be to either use scroll_container.scroll_vertical = 0, or scroll_container.reset_scroll(), since scroll() is an internal physics step function.

@shoyguer
Copy link
Contributor Author

all the 3 methods will work.

@scgm0
Copy link
Contributor

scgm0 commented Jan 17, 2026

It can be confirmed that this PR has resolved the issue I encountered in my project. Thank you!

@shoyguer shoyguer marked this pull request as ready for review January 17, 2026 04:32
@SpyrexDE
Copy link
Owner

@shoyguer The current state of the PR still seems very buggy compared to main. Especially when the scrollcotainer is being scaled:

Current main:

Screen.Recording.2026-01-19.at.14.54.37.mov

This PR:

Screen.Recording.2026-01-19.at.14.55.22.mov

@shoyguer
Copy link
Contributor Author

@SpyrexDE thanks!
I'll take a deep look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants