Conversation
|
A few things that likely need attention in this PR:
|
|
FYI, we could add a line to remove the lines within |
|
@kapsakcj , I have removed the 1.7-2602 files from this PR, because that seems to be where most of the comments are directed towards. The remaining images are intended to be built off of the staphb/vadr:1.7 image, which does not contain any models and was built last year. I have also added the new url for the vadr repository to the main readme and program licenses. I think I can work on updating the 'latest' vadr version (tag 1.7-26*) sometime later. The current staphb/vadr:latest vadr version is from 1.6.4. |
|
Next steps for this PR includes the creation of a vadr-1.7-slim base for these to use instead |
I do actually feel bad about adding so many images to one PR. I decided to add them all to this PR for one reason: the PR associated with individual images would all edit the same line in the main README.md causing merging conflicts. In theory, this would mean that I would need to make these images one at a time and get each PR approved before I started on the next. I only get sporadic spans of time to work on these, though, so I would never finish at that rate.
The images with the prospective tags of
1.7-{flu,hav,mpxv,rsv,sarscov2}are different from their 1.6.4 version in that they are now built off the 1.7 image instead of rebuilding vadr for each one.1.7-2602is the image with all the models and should replace the 'latest' tag (finally).I did check to see if there were new models for flu, hav, mpxv, rsv, and sarscov2, and it didn't look like there were new ones.
I updated each tools' readme to reflect updated versions of dependencies.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15)docker-builds/build-files/spades/3.12.0/Dockerfile)build-files/shigatyper/2.0.1/test.sh)docker-builds/build-files/spades/3.12.0/README.md)Knowing my luck, finally creating this PR means that new version of VADR will come out soon.