Skip to content

Plassembler 1.8.2#1552

Open
cwoodside1278 wants to merge 4 commits intoStaPH-B:masterfrom
cwoodside1278:plassembler-1.8.2
Open

Plassembler 1.8.2#1552
cwoodside1278 wants to merge 4 commits intoStaPH-B:masterfrom
cwoodside1278:plassembler-1.8.2

Conversation

@cwoodside1278
Copy link
Contributor

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number in build-files (i.e. docker-builds/build-files/spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. build-files/shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. docker-builds/build-files/spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

Description

Updated plassembler to 1.8.2 version from 1.8.1

  • created new directory structure plassember/1.8.2
  • changed to mambaorg/micromamba:2.5.0-ubuntu24.04 from the previous version
  • Updated the container-specific read me to plassember/1.8.2
  • Updated the main read me to include the new version

Diff output

diff -r build-files/plassembler/1.8.2/Dockerfile build-files/plassembler/1.8.1/Dockerfile
1c1
< ARG PLASSEMBLER_VERSION="1.8.2"
---
> ARG PLASSEMBLER_VERSION="1.8.1"
3c3
< FROM mambaorg/micromamba:2.5.0-ubuntu24.04 AS app
---
> FROM mambaorg/micromamba:2.3.0-ubuntu22.04 AS app
11c11
< LABEL base.image="mambaorg/micromamba:2.5.0-ubuntu24.04"
---
> LABEL base.image="mambaorg/micromamba:2.3.0-ubuntu22.04"

Test output

=> [test 1/4] WORKDIR /test 0.0s
=> [test 2/4] RUN plassembler --help && plassembler --version 1.8s
=> [test 3/4] RUN wget https://github.com/gbouras13/plassembler/archive/refs/tags/v1.8.2.tar.gz && tar -xvf v1.8.2.tar.gz && plassembler run -l plassembler 176.5s
=> [test 4/4] RUN micromamba list -n base

perl-types-serialiser 1.01 pl5321hdfd78af_0 bioconda
pip 25.2 pyh8b19718_0 conda-forge
pixman 0.46.4 h54a6638_1 conda-forge
plassembler 1.8.1 pyhdfd78af_0 bioconda
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the dependency list for 1.8.1.

Can you run

micromamba list -n base

inside the container to get an up-to-date list of dependencies and their versions?

@erinyoung
Copy link
Contributor

Tests looked like they worked

#12 11.35 2026-02-13 02:52:15 (10.5 MB/s) - ‘v1.8.2.tar.gz’ saved [115927796]
#12 11.35 
#12 11.36 plassembler-1.8.2/
#12 11.36 plassembler-1.8.2/.flake8
#12 11.36 plassembler-1.8.2/.github/
#12 11.36 plassembler-1.8.2/.github/ISSUE_TEMPLATE/
#12 11.36 plassembler-1.8.2/.github/ISSUE_TEMPLATE/bug_report.md
#12 11.36 plassembler-1.8.2/.github/ISSUE_TEMPLATE/feature_request.md
#12 11.36 plassembler-1.8.2/.github/workflows/
#12 11.36 plassembler-1.8.2/.github/workflows/ci.yaml
#12 11.36 plassembler-1.8.2/.github/workflows/release.yaml
#12 11.36 plassembler-1.8.2/.gitignore
#12 11.36 plassembler-1.8.2/.readthedocs.yaml
#12 11.36 plassembler-1.8.2/AUTHORS.md
#12 11.36 plassembler-1.8.2/CONTRIBUTING.md
#12 11.36 plassembler-1.8.2/HISTORY.md
#12 11.36 plassembler-1.8.2/LICENSE
#12 11.36 plassembler-1.8.2/README.md
#12 11.36 plassembler-1.8.2/build/
#12 11.36 plassembler-1.8.2/build/environment.yaml
#12 11.36 plassembler-1.8.2/docs/
#12 11.36 plassembler-1.8.2/docs/benchmarking_results_real.md
#12 11.36 plassembler-1.8.2/docs/benchmarking_results_sim.md
#12 11.36 plassembler-1.8.2/docs/citation.md
#12 11.36 plassembler-1.8.2/docs/fastqs.md
#12 11.36 plassembler-1.8.2/docs/flye_non_determinism.md
#12 11.36 plassembler-1.8.2/docs/index.md
#12 11.36 plassembler-1.8.2/docs/install.md
#12 11.36 plassembler-1.8.2/docs/long.md
#12 11.36 plassembler-1.8.2/docs/long_old.md
#12 11.36 plassembler-1.8.2/docs/metagenomics.md
#12 11.36 plassembler-1.8.2/docs/method.md
#12 11.36 plassembler-1.8.2/docs/multiple_chromosome.md
#12 11.36 plassembler-1.8.2/docs/output.md
#12 11.36 plassembler-1.8.2/docs/quality_control.md
#12 11.36 plassembler-1.8.2/docs/reasons.md
#12 11.36 plassembler-1.8.2/docs/requirements.txt
#12 11.36 plassembler-1.8.2/docs/run.md
#12 11.36 plassembler-1.8.2/img/
#12 11.36 plassembler-1.8.2/img/Figure1.png
#12 11.37 plassembler-1.8.2/justfile
#12 11.37 plassembler-1.8.2/pyproject.toml
#12 11.37 plassembler-1.8.2/requirements.txt
#12 11.37 plassembler-1.8.2/run_plassembler.ipynb
#12 11.37 plassembler-1.8.2/src/
#12 105.6 2026-02-13 02:53:49.549 | INFO     | plassembler.utils.external_tools:run:58 - Started running unicycler -1 output_test/short_read_concat_R1.fastq -2 output_test/short_read_concat_R2.fastq -l output_test/plasmid_long.fastq -t 4 -o output_test/unicycler_output ...
#12 135.1 2026-02-13 02:54:19.015 | INFO     | plassembler.utils.external_tools:run:60 - Done running unicycler -1 output_test/short_read_concat_R1.fastq -2 output_test/short_read_concat_R2.fastq -l output_test/plasmid_long.fastq -t 4 -o output_test/unicycler_output
#12 135.1 2026-02-13 02:54:19.017 | INFO     | plassembler.utils.external_tools:run_to_stdout:67 - Started running minimap2 -ax map-ont -t 4 output_test/combined.fasta output_test/chopper_long_reads.fastq.gz ...
#12 135.5 2026-02-13 02:54:19.401 | INFO     | plassembler.utils.external_tools:run_to_stdout:69 - Done running minimap2 -ax map-ont -t 4 output_test/combined.fasta output_test/chopper_long_reads.fastq.gz
#12 135.5 2026-02-13 02:54:19.401 | INFO     | plassembler.utils.external_tools:run:58 - Started running samtools sort -@ 4 output_test/combined_long.sam -o output_test/combined_sorted_long.bam ...
#12 135.6 2026-02-13 02:54:19.471 | INFO     | plassembler.utils.external_tools:run:60 - Done running samtools sort -@ 4 output_test/combined_long.sam -o output_test/combined_sorted_long.bam
#12 135.6 2026-02-13 02:54:19.472 | INFO     | plassembler.utils.external_tools:run_to_stdout:67 - Started running minimap2 -ax sr -t 4 output_test/combined.fasta output_test/trimmed_R1.fastq output_test/trimmed_R2.fastq ...
#12 135.8 2026-02-13 02:54:19.723 | INFO     | plassembler.utils.external_tools:run_to_stdout:69 - Done running minimap2 -ax sr -t 4 output_test/combined.fasta output_test/trimmed_R1.fastq output_test/trimmed_R2.fastq
#12 135.8 2026-02-13 02:54:19.723 | INFO     | plassembler.utils.external_tools:run:58 - Started running samtools sort -@ 4 output_test/combined_short.sam -o output_test/combined_sorted_short.bam ...
#12 135.9 2026-02-13 02:54:19.847 | INFO     | plassembler.utils.external_tools:run:60 - Done running samtools sort -@ 4 output_test/combined_short.sam -o output_test/combined_sorted_short.bam
#12 136.2 2026-02-13 02:54:20.110 | INFO     | plassembler:run:683 - Calculating mash distances to PLSDB.
#12 136.2 2026-02-13 02:54:20.111 | INFO     | plassembler.utils.external_tools:run:58 - Started running mash sketch output_test/plasmids.fasta -i ...
#12 136.2 2026-02-13 02:54:20.122 | INFO     | plassembler.utils.external_tools:run:60 - Done running mash sketch output_test/plasmids.fasta -i
#12 136.2 2026-02-13 02:54:20.122 | INFO     | plassembler.utils.external_tools:run_to_stdout:67 - Started running mash dist output_test/plasmids.fasta.msh /plassembler_db/plsdb_2023_11_03_v2.msh -v 0.1 -d 0.1 -i ...
#12 138.6 2026-02-13 02:54:22.516 | INFO     | plassembler.utils.external_tools:run_to_stdout:69 - Done running mash dist output_test/plasmids.fasta.msh /plassembler_db/plsdb_2023_11_03_v2.msh -v 0.1 -d 0.1 -i
#12 139.2 2026-02-13 02:54:23.114 | INFO     | plassembler.utils.plass_class:combine_depth_mash_tsvs:754 - Filtering contigs below depth filter: 0.25.
#12 139.2 2026-02-13 02:54:23.114 | INFO     | plassembler.utils.plass_class:combine_depth_mash_tsvs:756 - All plasmids whose short and long read copy numbers are both below 0.25 will be removed.
#12 139.2 2026-02-13 02:54:23.114 | INFO     | plassembler.utils.plass_class:combine_depth_mash_tsvs:772 - No plasmids were filtered due to low depth.
#12 139.2 2026-02-13 02:54:23.145 | INFO     | plassembler:end_plassembler:118 - Plassembler has finished
#12 139.2 2026-02-13 02:54:23.145 | INFO     | plassembler:end_plassembler:119 - Elapsed time: 126.26 seconds
#12 139.3 flye_output
#12 139.3 logs
#12 139.3 plassembler_1770951136.8832204.log
#12 139.3 plassembler_plasmids.fasta
#12 139.3 plassembler_plasmids.gfa
#12 139.3 plassembler_summary.tsv
#12 139.3 unicycler_output

@erinyoung
Copy link
Contributor

I added another file to your PR due to updating the workflow for a github action (GA). Plassembler uses third-party databases, so we have a GA that updates the latest plassembler image semi-frequently. It should not impact the main image in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants