Add ncov-recombinant v0.6.1 APHL Docker Workshop#583
Open
whottel wants to merge 8 commits intoStaPH-B:masterfrom
Open
Add ncov-recombinant v0.6.1 APHL Docker Workshop#583whottel wants to merge 8 commits intoStaPH-B:masterfrom
whottel wants to merge 8 commits intoStaPH-B:masterfrom
Conversation
erinyoung
reviewed
Feb 8, 2023
ncov-recombinant/0.6.1/Dockerfile
Outdated
Comment on lines
19
to
22
| RUN apt-get update && apt-get install -y python \ | ||
| git \ | ||
| wget && \ | ||
| rm -rf /var/lib/apt/lists/* && apt-get autoclean |
Contributor
There was a problem hiding this comment.
We have found that images are smaller when using --no-install-recommends
Could you adjust line 19 to
apt-get update && apt-get install --no-install-recommends -y python \
erinyoung
reviewed
Feb 8, 2023
ncov-recombinant/0.6.1/Dockerfile
Outdated
Comment on lines
25
to
26
| RUN git clone https://github.com/ktmeaton/ncov-recombinant.git &&\ | ||
| cd ncov-recombinant |
Contributor
There was a problem hiding this comment.
Instead of using git clone, could you download the tarball for the version you are creating an image for?
# something like
wget https://github.com/ktmeaton/ncov-recombinant/archive/refs/tags/v0.6.1.tar.gz
git clone is hard for version control
You image will also likely be smaller and more stable if you download the tarball and install it from that as well (instead of using micromamba). Did you already try that?
Contributor
|
Your Dockerfile built successfully and your test worked. I was going to copy the results of the tests, but it's a lot of lines. Github actions failed because your image is missing |
Contributor
|
Were you able to get your permissions issues figured out? |
Author
|
Unfortunately, I am still getting errors. When I explicitly state where the Snakefile should be with I get this error: |
Contributor
|
I was working on this today, and I actually got this to work (to a point). I tried to run the tutorial, but there's something wrong with a python script included in the repo (I keep getting type errors when I run the tutorial or other profiles). I'm currently on the mindset that we should wait until https://github.com/phac-nml/rebar has a released version and close this PR. |
Author
|
Thanks for looking into this. -Wes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for ncov-recombinant version 0.6.1. The dockerfile uses micromamba as the base image.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15)spades/3.12.0/Dockerfile)shigatyper/2.0.1/test.sh)spades/3.12.0/README.md)