Skip to content

Conversation

@Darko1green1LOrd
Copy link

This change allows to edit ComponentsV2 sent as long as the message is sent with the webhook that you are trying to edit it with

@Darko1green1LOrd
Copy link
Author

Forgot to make the Load button actually load the contents of the message to edit, will add that when i have that done

@kpodp0ra
Copy link
Member

Great contribution, thanks! Let me know when it's ready so i can review it.

@Darko1green1LOrd
Copy link
Author

Great contribution, thanks! Let me know when it's ready so i can review it.

Thanks, got loading the message working, unfortionatly loading link buttons with no emoji results in a empty space in size of regular emoji as the raw data on discord s side is bit different but it does work, tried to make it not display that gap for quite some time unfortionatly unsuccesfully

@Darko1green1LOrd
Copy link
Author

Though it was done, not done #74
Will either need to figure out how to make it load all the data from discord raw data properly or disable the load message from discord for editing and just leave in the ability to edit a message sent by the webhook

@Darko1green1LOrd
Copy link
Author

Looks like only ids for the main components caused that problem, doesnt cause any problems in nested components in components

@Darko1green1LOrd
Copy link
Author

@kpodp0ra I have tested all the changed things and it works with no problems, hopefully the same thing goes for review

@Darko1green1LOrd
Copy link
Author

Oh, i was just updating the readme in my fork as i felt some info was missing and also my icons didnt load on the dev server, didnt realize it automatically added them to the merge request even tho it doesnt have to doanything with message editing

@kpodp0ra kpodp0ra self-requested a review May 14, 2025 14:14
@Darko1green1LOrd
Copy link
Author

Darko1green1LOrd commented May 14, 2025

@kpodp0ra i added also option for setting the username and avatar for the message withouth having to change the webhook s avatar and username, should i wait till the review is done and make a new pull request or commit the changes now and just like with the readme it will probably automatically add itself to this request, that change is also fully tested and works withouth problems

@kpodp0ra
Copy link
Member

@Darko1green1LOrd don't worry about formal things, upload everything here and i'll sort and document it myself

@Darko1green1LOrd
Copy link
Author

@Darko1green1LOrd don't worry about formal things, upload everything here and i'll sort and document it myself

Alr, thanks

@kpodp0ra
Copy link
Member

btw i also use linux and without {find: /^components-sdk.*$/, replacement: resolve(__dirname, '../components-sdk/src')}, i don't get updates on compontents-sdk (i must do yarn build every time)

if you have any issues, go to node_modules folder and delete .vite ( it can be safely deleted ) — maybe this will help

@Darko1green1LOrd
Copy link
Author

Ah thanks, interesting, tried deleting .vite, didnt help
and for me commeting the alias fixes the problem of no assets from components-sdk loading
with the alias it gives me buch of 404 errors and either i need to ignore the fact that the icons arent there or do yarn build everytime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants