-
Notifications
You must be signed in to change notification settings - Fork 35
Add Message Editing #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Forgot to make the Load button actually load the contents of the message to edit, will add that when i have that done |
|
Great contribution, thanks! Let me know when it's ready so i can review it. |
Thanks, got loading the message working, unfortionatly loading link buttons with no emoji results in a empty space in size of regular emoji as the raw data on discord s side is bit different but it does work, tried to make it not display that gap for quite some time unfortionatly unsuccesfully |
|
Though it was done, not done #74 |
|
Looks like only ids for the main components caused that problem, doesnt cause any problems in nested components in components |
|
@kpodp0ra I have tested all the changed things and it works with no problems, hopefully the same thing goes for review |
… you attempt to move a loaded button with no icon outside of its component set
|
Oh, i was just updating the readme in my fork as i felt some info was missing and also my icons didnt load on the dev server, didnt realize it automatically added them to the merge request even tho it doesnt have to doanything with message editing |
|
@kpodp0ra i added also option for setting the username and avatar for the message withouth having to change the webhook s avatar and username, should i wait till the review is done and make a new pull request or commit the changes now and just like with the readme it will probably automatically add itself to this request, that change is also fully tested and works withouth problems |
|
@Darko1green1LOrd don't worry about formal things, upload everything here and i'll sort and document it myself |
Alr, thanks |
|
btw i also use linux and without if you have any issues, go to |
|
Ah thanks, interesting, tried deleting .vite, didnt help |
This change allows to edit ComponentsV2 sent as long as the message is sent with the webhook that you are trying to edit it with