This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Add tqdm and trange imports for progress tracking when indexing #59#68
Open
Suvendu-UI wants to merge 2 commits intoStoria-AI:mainfrom
Open
Add tqdm and trange imports for progress tracking when indexing #59#68Suvendu-UI wants to merge 2 commits intoStoria-AI:mainfrom
Suvendu-UI wants to merge 2 commits intoStoria-AI:mainfrom
Conversation
iuliaturc
suggested changes
Oct 10, 2024
Contributor
iuliaturc
left a comment
There was a problem hiding this comment.
Hi @Suvendu-UI, thanks for your PR! I'm trying to run this but I'm seeing some some syntax errors:
File "my-venv/bin/sage-index", line 5, in <module>
from sage.index import main
File "sage/sage/index.py", line 12, in <module>
from sage.embedder import build_batch_embedder_from_flags
File "sage/sage/embedder.py", line 397
for chunk, embedding in tqdm(zip(batch, result["embedding"]):)
^
SyntaxError: invalid syntax
Could you please address them? Here's the command I used (you'll need to have a pinecone account):
sage-index iuliaturc/detextify --mode=remote --pinecone-index-name=your-pinecone-index
Author
|
this error is showing due to a hit in the billing hard limit in my free account |
Contributor
|
@Suvendu-UI it actually looks like a syntax error, I believe the semicolon should be after the closed paranthesis. |
Contributor
|
@Suvendu-UI Just checking in: are you still working on this issue or should I take over? |
Author
|
I am very sorry pls take it over |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
it solves the issue of progress bar while indexing
Fixes # 59
Before submitting
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who
may be interested in your PR.