Skip to content

🐛 Handle UPPERCASE in exacturl operator #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
homersimpsons wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛 Handle UPPERCASE in exacturl operator #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 70 additions & 0 deletions crates/core/src/query/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1244,6 +1244,48 @@ mod tests {
.unwrap(),
)
.expect("failed to insert webpage");
index
.insert(
&Webpage::test_parse(
&format!(
r#"
<html>
<head>
<title>Test page with trailing slash</title>
</head>
<body>
This is a test page with a trailing slash {}
</body>
</html>
"#,
rand_words(1000)
),
"https://www.example.com/trailing-slash/",
)
.unwrap(),
)
.expect("failed to insert webpage");
index
.insert(
&Webpage::test_parse(
&format!(
r#"
<html>
<head>
<title>Test page with UPPERCASE link</title>
</head>
<body>
This is a test page with an UPPERCASE link {}
</body>
</html>
"#,
rand_words(1000)
),
"https://www.example.com/UPPERCASE",
)
.unwrap(),
)
.expect("failed to insert webpage");
index.commit().expect("failed to commit index");
let searcher = LocalSearcher::builder(Arc::new(RwLock::new(index))).build();

Expand All @@ -1260,6 +1302,34 @@ mod tests {
};
let result = searcher.search_sync(&query).expect("Search failed");
assert_eq!(result.webpages.len(), 0);

let query = SearchQuery {
query: "test exacturl:https://www.example.com/trailing-slash/".to_string(),
..Default::default()
};
let result = searcher.search_sync(&query).expect("Search failed");
assert_eq!(result.webpages.len(), 1);

let query = SearchQuery {
query: "test exacturl:https://www.example.com/trailing-slash".to_string(),
..Default::default()
};
let result = searcher.search_sync(&query).expect("Search failed");
assert_eq!(result.webpages.len(), 0);

let query = SearchQuery {
query: "test exacturl:https://www.example.com/UPPERCASE".to_string(),
..Default::default()
};
let result = searcher.search_sync(&query).expect("Search failed");
assert_eq!(result.webpages.len(), 1);

let query = SearchQuery {
query: "test exacturl:https://www.example.com/uppercase".to_string(),
..Default::default()
};
let result = searcher.search_sync(&query).expect("Search failed");
assert_eq!(result.webpages.len(), 0);
}

#[test]
Expand Down
2 changes: 1 addition & 1 deletion crates/core/src/schema/text_field.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,7 @@ impl TextField for UrlNoTokenizer {
}

fn query_tokenizer(&self, _: Option<&whatlang::Lang>) -> FieldTokenizer {
FieldTokenizer::Words(WordTokenizer::default())
FieldTokenizer::Identity(Identity {})
}

fn is_searchable(&self) -> bool {
Expand Down