Removed Starknet dependencies and installed Stellar dependencies#259
Removed Starknet dependencies and installed Stellar dependencies#259chiscookeke11 wants to merge 4 commits intoStreamFi-x:devfrom
Conversation
|
@chiscookeke11 is attempting to deploy a commit to the david's projects Team on Vercel. A member of the Team first needs to authorize it. |
davedumto
left a comment
There was a problem hiding this comment.
Review — Changes Requested
Hey! The core task is done correctly — all 4 StarkNet packages removed and all 3 Stellar packages installed. Nice work on that part.
However, there are several unrelated version changes in this PR that will cause issues down the line. It looks like these may have happened from trying to get past a husky/lint hook failure — if that was the case, using git push --no-verify or npx husky install would have been the easier fix. Here's what needs to be reverted:
Unrelated version changes to revert
| Package | Changed from | Changed to | Issue |
|---|---|---|---|
next |
^14.2.29 |
^16.1.6 |
2 major version jump — breaks routing, middleware, config |
eslint |
^9 |
^4.1.1 |
Downgraded to 2017 version — breaks all linting |
eslint-config-next |
15.1.6 |
^0.2.4 |
Ancient version, incompatible with project |
husky |
^9.1.7 |
^8.0.0 |
Downgrade breaks git hooks |
nodemailer |
^6.10.1 |
^8.0.1 |
Unauthorized major bump |
swiper |
^11.2.4 |
^12.1.2 |
Unauthorized major bump |
commitizen |
^4.3.1 |
^4.2.4 |
Unnecessary downgrade |
The prepare script also changed from "husky" to "husky && husky install" — this mixes v8/v9 syntax and should be reverted to "husky".
Missing
package-lock.json— Issue #230 lists this as an affected file- Loom video — Required by the issue template
How to fix
- Revert
package.jsonto only contain the StarkNet removal + Stellar additions (no other version changes) - Run
npm installcleanly and include thepackage-lock.json - If husky blocks your push, use
git push --no-verify(this is fine for a dependency-only PR)
The Stellar packages themselves look good — just need to clean up the extra changes. Thanks!
9756b52 to
c2df0e8
Compare
Fixed |
CI/CD Failure: SwiperJS VulnerabilityOne of the CI/CD checks is failing due to a critical prototype pollution vulnerability in
How to fix
The workflow is configured to fail on high severity vulnerabilities — upgrading swiper to |
|
once this is fixed I can merge |
|
alternatively you can do this |
|
Alright |
|
the cicd is still failing, next js version need an update too, kindly do that |


Description
This PR removes the previous StarkNet dependencies from the frontend and installs the Stellar SDK packages in preparation for migrating StreamFi’s wallet authentication to Stellar.
_Closes #230
Changes proposed
What were you told to do?
Install Stellar SDK packages and remove StarkNet dependencies
What did you do?
package.jsonandpackage-lock.json.@stellar/stellar-sdkand@stellar/freighter-api.npm installruns successfully without errors.Check List (Check all the applicable boxes)
🚨Please review the contribution guideline for this repository.
Screenshots
Screen record:
https://www.loom.com/share/10dbe11329c146cf9a463ab5e35732c3