Skip to content

Removed Starknet dependencies and installed Stellar dependencies#259

Open
chiscookeke11 wants to merge 4 commits intoStreamFi-x:devfrom
chiscookeke11:issue-230
Open

Removed Starknet dependencies and installed Stellar dependencies#259
chiscookeke11 wants to merge 4 commits intoStreamFi-x:devfrom
chiscookeke11:issue-230

Conversation

@chiscookeke11
Copy link
Contributor

@chiscookeke11 chiscookeke11 commented Feb 19, 2026

Description

This PR removes the previous StarkNet dependencies from the frontend and installs the Stellar SDK packages in preparation for migrating StreamFi’s wallet authentication to Stellar.

_Closes #230

Changes proposed

What were you told to do?

Install Stellar SDK packages and remove StarkNet dependencies

What did you do?

  • Uninstalled all 4 StarkNet packages from package.json and package-lock.json.
  • Installed Stellar packages @creit.tech/stellar-wallets-kit, @stellar/stellar-sdk and @stellar/freighter-api.
  • Verified that npm install runs successfully without errors.
  • Left broken imports from StarkNet untouched (expected at this stage).

Check List (Check all the applicable boxes)

🚨Please review the contribution guideline for this repository.

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.
  • I am making a pull request against the main branch (left side).
  • My commit messages styles matches our requested structure.
  • My code additions will fail neither code linting checks nor unit test.
  • I am only making changes to files I was requested to.

Screenshots

Screenshot 2026-02-20 000738 Screenshot 2026-02-20 000949 Screenshot 2026-02-20 001002

Screen record:

https://www.loom.com/share/10dbe11329c146cf9a463ab5e35732c3

@vercel
Copy link

vercel bot commented Feb 19, 2026

@chiscookeke11 is attempting to deploy a commit to the david's projects Team on Vercel.

A member of the Team first needs to authorize it.

@chiscookeke11 chiscookeke11 marked this pull request as draft February 19, 2026 23:24
@chiscookeke11 chiscookeke11 marked this pull request as ready for review February 19, 2026 23:32
Copy link
Contributor

@davedumto davedumto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review — Changes Requested

Hey! The core task is done correctly — all 4 StarkNet packages removed and all 3 Stellar packages installed. Nice work on that part.

However, there are several unrelated version changes in this PR that will cause issues down the line. It looks like these may have happened from trying to get past a husky/lint hook failure — if that was the case, using git push --no-verify or npx husky install would have been the easier fix. Here's what needs to be reverted:

Unrelated version changes to revert

Package Changed from Changed to Issue
next ^14.2.29 ^16.1.6 2 major version jump — breaks routing, middleware, config
eslint ^9 ^4.1.1 Downgraded to 2017 version — breaks all linting
eslint-config-next 15.1.6 ^0.2.4 Ancient version, incompatible with project
husky ^9.1.7 ^8.0.0 Downgrade breaks git hooks
nodemailer ^6.10.1 ^8.0.1 Unauthorized major bump
swiper ^11.2.4 ^12.1.2 Unauthorized major bump
commitizen ^4.3.1 ^4.2.4 Unnecessary downgrade

The prepare script also changed from "husky" to "husky && husky install" — this mixes v8/v9 syntax and should be reverted to "husky".

Missing

  • package-lock.json — Issue #230 lists this as an affected file
  • Loom video — Required by the issue template

How to fix

  1. Revert package.json to only contain the StarkNet removal + Stellar additions (no other version changes)
  2. Run npm install cleanly and include the package-lock.json
  3. If husky blocks your push, use git push --no-verify (this is fine for a dependency-only PR)

The Stellar packages themselves look good — just need to clean up the extra changes. Thanks!

@chiscookeke11
Copy link
Contributor Author

Review — Changes Requested

Hey! The core task is done correctly — all 4 StarkNet packages removed and all 3 Stellar packages installed. Nice work on that part.

However, there are several unrelated version changes in this PR that will cause issues down the line. It looks like these may have happened from trying to get past a husky/lint hook failure — if that was the case, using git push --no-verify or npx husky install would have been the easier fix. Here's what needs to be reverted:

Unrelated version changes to revert

Package Changed from Changed to Issue
next ^14.2.29 ^16.1.6 2 major version jump — breaks routing, middleware, config
eslint ^9 ^4.1.1 Downgraded to 2017 version — breaks all linting
eslint-config-next 15.1.6 ^0.2.4 Ancient version, incompatible with project
husky ^9.1.7 ^8.0.0 Downgrade breaks git hooks
nodemailer ^6.10.1 ^8.0.1 Unauthorized major bump
swiper ^11.2.4 ^12.1.2 Unauthorized major bump
commitizen ^4.3.1 ^4.2.4 Unnecessary downgrade
The prepare script also changed from "husky" to "husky && husky install" — this mixes v8/v9 syntax and should be reverted to "husky".

Missing

How to fix

  1. Revert package.json to only contain the StarkNet removal + Stellar additions (no other version changes)
  2. Run npm install cleanly and include the package-lock.json
  3. If husky blocks your push, use git push --no-verify (this is fine for a dependency-only PR)

The Stellar packages themselves look good — just need to clean up the extra changes. Thanks!

Fixed
Please review

@davedumto
Copy link
Contributor

CI/CD Failure: SwiperJS Vulnerability

One of the CI/CD checks is failing due to a critical prototype pollution vulnerability in swiper@11.2.10.

Advisory: GHSA-hmx5-qpq5-p643


How to fix

  1. Update swiper in package.json:

    "swiper": "^11.2.11"
  2. Reinstall and commit:

    npm install
    git add package.json package-lock.json
    git commit -m "fix: upgrade swiper to mitigate prototype pollution vulnerability"
    git push

The workflow is configured to fail on high severity vulnerabilities — upgrading swiper to >=11.2.11 (or latest) directly addresses the root cause.

@davedumto
Copy link
Contributor

once this is fixed I can merge

@chiscookeke11
Copy link
Contributor Author

once this is fixed I can merge

Please I got this:

image

@davedumto
Copy link
Contributor

alternatively you can do this npm install swiper@latest remove the other version you added and just run this

@chiscookeke11
Copy link
Contributor Author

Alright

@chiscookeke11
Copy link
Contributor Author

Done

image

@davedumto
Copy link
Contributor

the cicd is still failing, next js version need an update too, kindly do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments