Skip to content

Conversation

@mrmoss
Copy link

@mrmoss mrmoss commented Jun 8, 2022

Description

  1. Command sumocli login seems to have been replaced with sumocli configure but docs were not updated
  2. Addresses Add the ability to have multiple credential profiles  #91 by adding an environment variable to select which configuration name is loaded via viper

Note: Someone from sumo should probably build the sumocli binary and upload it here...because I wouldn't trust me.

Before

Command sumocli login is in the docs but sumocli configure is used

Configuration was hardcoded to creds

After

Command sumocli configure is in the docs and sumocli configure is used

Configuration is determined by env["SUMO_CONFIG_NAME"] || "creds"

Type of change

Please delete options that are not relevant.

  • [y] New feature (non-breaking change which adds functionality)
  • [n] This change requires a documentation update

Checklist:

  • [y] My code follows the style guidelines of this project
  • [y] I have performed a self-review of my own code
  • [y] I have commented my code, particularly in hard-to-understand areas
  • [y] I have made corresponding changes to the documentation

@wizedkyle
Copy link
Contributor

@mrmoss Thank you for submitting a PR, I'll take a look at this one shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants