Merged
Conversation
…in ionosphere, unfinished code
… cartopy for geographic
…c with documentation, just not implemented due to inconsistent fill
…lculation in geo from Shibaji and Xueling code
EHN: Boxcar Filter
EHN: Single Beam Options
EHN: Tdiff Correction for Elevation Data
FIX: Correct where partial record check occurs in Grid plot
carleyjmartin
commented
Dec 13, 2023
This comment was marked as resolved.
This comment was marked as resolved.
New Feature: IQ Data Plots
* Changed all classmethods to staticmethods * Created staticmethod plot_acf_param() to handle plotting of values, which is called within plot_acfs() as needed to plot real, imaginary, power, and phase of ACF * Return all axes from plot_acfs() as list * Plot real and imaginary ACF values on input ax to plot_acfs() if plot_pwr_and_phs False, otherwise use plt.gca() * Removed some unnecessary internal variables in plot_acfs().
* Useful for bistatic experiments especially, also applicable to normal operations
* The returned phase array from plot_acfs() now also returns values in radians.
Major refactor of acf.py
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
Author
|
Thanks for testing everyone! |
New time of flight range estimation
carleyjmartin
commented
Dec 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyDARN Version 4.0
Deadline: 21st December 2023
Important Notes:
Scope
This major release includes:
Some of which are yet to be merged in so please go check out the active PR's first! #307 #338 #343 #353 #355 #356
I have ordered the author list in the zenodo by contribution, developers first, then testers, then previous large contributors to the project in alphabetical order, let me know if there is anyone missing!
Approval
Number of approvals: 3 code review and testing
Test
Testing Checklist (feel free to tick off what you do so at least one person has tested everything):
Are your details in the .zenodo.json file correct and are you happy with your coauthor position (email Carley if you are missing!)?
Make sure the library installs properly using
pip3 install git+https://github.com/superdarn/pydarn@release/4.0Install by git clone and use pytest - process is below (this only tests that the methods work without error, this does not test that the output of the methods are scientifically correct - that's where you come in ;) ).
Read the documentation (link below), is there anything that wasn't helpful, missing or could be explained better?
Code review - read the lines of code changed (Files Changed tab above), do they make sense, are they optimal?
Generally test the following methods using as many keyword combos as you can (use documentation linked below to write code):
{'ax': ax, 'ccrs': ccrs, 'cm': cmap, 'cb': cb, 'fig': plt.gcf(), 'data': {}}Where data contains any interesting plot data you might like to use.Specific new features that need testing (should also be in documentation and see linked PRs for testing info but make sure you test on this release branch, they have already been tested individually):
You may need to amend any old code to work - this is expected and probably not a bug!
Please comment to say everything worked (if so please tick the approve box on Files Changed - > Review Changes -> Approve + type any comments in box -> Submit Review).
If there are errors please comment your code used, the traceback and any errors/warnings in the command line, and any output plots if any.
For approvals or errors, please specify your OS, python version, matplotlib version and installation process. Thanks :)
I will likely add to this when newer PRs are merged in later.
Please tick if you have successfully tested using:
Here are some misc data files that you can use to test with:
fitacf.zip
maps_n_grids.zip
Rawacf is too big for github but you can get any off FRDR
Additional little things
Read the docs link will appear here when I've done it: https://pydarn.readthedocs.io/en/release-4.0/
pytest modules have been updated, you can run pytest by cloning the repository, moving to this release branch, installing the branch, installing pytest and running pytest (this may take 5-10 minutes to run all tests):
As always, if you need help installing and testing, feel free to give me an email.
Thanks for everyone's help this year on this release!
Carley