Open
Conversation
Contributor
|
I guess there is nothing to test here... |
Contributor
Author
|
If this looks good and you trust the compilation test or have tested a compilation yourself, that should work. I could also supply the file and instructions to test if that would be helpful. |
Member
|
What about addressing the root cause of fitacf3 trying to fit data with nave = 0 (as mentioned in #650)? |
Contributor
Author
|
I agree the root cause is good to check on, but this pull request is a quick reaction to the offending code from what we discussed at the last meeting. I'm sure we could add a check for nave to fitacf3 in another pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we discussed in the Nov. 2025 Data Analysis Working Group meeting, some of the regenerated
cve,cvwhave-nanvalues in the acfd and other data arrays. These values cause the current fitacf3 processing to output a lot of warning messages about calculated values that are also-nan.This pull request comments out the check for
-nanand the subsequent warning print statement. An example file which this fixes is the20201231.0601.00.cvw.rawacf.bz2file.