Change attenuation variable being used by make_raw#653
Open
Change attenuation variable being used by make_raw#653
Conversation
…ead of atten value in radar parameter block, for consistency with on-site radar software
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request modifies the
make_rawbinary to use theiq->attenvalues instead ofprm->attenwhen callingACFSumPower. This is both for consistency with the on-site radar processing software (eg, https://github.com/SuperDARN/ros-archive/blob/ros.1.25/qnx/code/src.lib/radarqnx4/integrategc214.1.29/src/integrategc214.c#L326-L329), and to avoid conflicts with recent changes to US USRP-style radars that use the (previously unused)prm->attenfield to track attenuation and amplification settings in the receiver front-end cards.Note this branch was based on the 5.1.1 release, so it should not be merged into develop until after that release is finalized.