Merged
Conversation
* `python/` directory contains wrapper around API exported by pyo3, simplifying API considerably * Refactored Rust API to use the `Record` trait for reading and writing exclusively, removing "convenience" functions `read_[type]`, `write_[type]` * Some internal refactoring of functions and modules * Anything that used to take a `PathBuf` now takes `AsRef<Path>` * Added LGPLv3 license
* Updated READMEs * Python API defaults to "lax" reading mode * Cleaned up a lot of clippy warnings
* Fixed Python API * Added badges * Added .gitignore * Changed crate name to `darn-dmap` for crates.io
* Also ran `ruff` over the Python codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This release moves to a mixed Python/Rust project, featuring a more user-friendly Python API with integration tests on the API. It also bumps
pyo3to 0.26.0, which adds support up to Python 3.14.Python API
The functions below show the generic read/write ability of this package. Additionally, there are specific functions for each SuperDARN file type (
iqdat,rawacf,fitacf,grid,map, andsnd). These are structured identically, but conduct more tests to determine that the data is compliant with the specific file format (i.e. all required fields are present, no additional fields are present, fields have the expected data type, etc.).Rust API
This can be seen by cloning the repo and running
cargo docto generate the HTML documentation. Once this crate is published, you can search for thedarn-dmapcrate on https://docs.rs/.