Expose colorscheme, scrollbar, clipboard functionality to QML #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose a subset of the ColorSchemeManager to QML in order to allow editing of ColorSchemes from within QML.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on modernizing lomiri-terminal-app which is a continuation of the ubuntu-terminal-app from Ubuntu Touch and now part of the Lomiri project. ubuntu-terminal-app is built on a heavily modified, vendored fork of qmltermwidget from the lxqt project. Rather than maintaining this in parallel we'd rather prefer to join forces, particularly since this fork of qmltermwidget is already packaged in major distributions. This PR exposes some additional functionality to QML in order to make lomiri-terminal-app work with qmltermwidget. The most important change is the exposition of
ColorSchemeManagerandColorSchemesince we provide a QML-based color scheme editor as part of our settings dialogue. We are also using our own scrollbar based on our own QML components library. Finally, we need some additional clipboard/selection functionality in order to show popovers on paste.