Skip to content
This repository was archived by the owner on Oct 8, 2025. It is now read-only.

Conversation

@dnna
Copy link
Contributor

@dnna dnna commented Aug 21, 2020

For select attributes, the translations set in the attribute configuration aren't used, but instead, the UUIDs are shown with no way for the user to fetch the real string. See below screenshot for an example:

image

This PR fixes this by specifically handling this case and retrieving the correct string for use in the API instead of the UUID.

@dnna dnna requested a review from a team as a code owner August 21, 2020 11:53
@mamazu
Copy link
Contributor

mamazu commented Aug 21, 2020

Thanks you for your contribution. Would you mind showing an example on how the API response will look after the PR?

Second I don't think replacing the UUID strings is a good idea. People using the API will rely on that. I'd rather suggest introducing them in a separate property.

Other than that it looks good. Would you mind changing the tests and documentation to reflect your changes? If you need any help feel free to ask. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants