[TwigHooks] Fix Twig 3 deprecations #311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrobat
commented
Nov 21, 2025
| $hookContext = $this->parseMultitargetExpression(); | ||
| } else { | ||
| // Remove when Twig 3.21 support is dropped | ||
| $hookContext = $this->parser->getExpressionParser()->parseMultitargetExpression(); |
Author
There was a problem hiding this comment.
This method is deprecated and no alternative is provided. In twig the usage of this method was replaced by a private method, so I'm applying the same logic here
twigphp/Twig@42c82e1#diff-c4fd0102f3bc6095b6b2c644eed251b98a65e46d2ed80329d97e9da3e97b984f
acrobat
force-pushed
the
fix-twig3-deprecations
branch
from
17b7308 to
d72e186
Compare
Author
|
I've fixed the code style errors of the previous build, can someone approve the build to run again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Twig 3 deprecations reported in #307