Skip to content

Import #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rbuergi merged 57 commits into from
Nov 3, 2025
Merged

Import #59

rbuergi merged 57 commits into from
Nov 3, 2025

Conversation

@rbuergi
Copy link
Contributor

@rbuergi rbuergi commented Oct 29, 2025

Importing through CollectionPlugin

@github-actions
Copy link

github-actions bot commented Oct 29, 2025 •
edited
Loading

Test Results

483 tests  +8   477 ✅ +8   2m 40s ⏱️ +41s
 21 suites ±0     6 💤 ±0 
 21 files   ±0     0 ❌ ±0 

Results for commit 48e724a. ± Comparison against base commit 32cc6d2.

This pull request removes 10 and adds 18 tests. Note that renamed tests count towards both. 
MeshWeaver.Hosting.Monolith.Test.ArticlesBlobStorageTest ‑ BasicArticle
MeshWeaver.Hosting.Monolith.Test.ArticlesBlobStorageTest ‑ Catalog
MeshWeaver.Hosting.Monolith.Test.ArticlesBlobStorageTest ‑ NotFound
MeshWeaver.Hosting.Monolith.Test.ArticlesTest ‑ BasicArticle
MeshWeaver.Hosting.Monolith.Test.ArticlesTest ‑ Catalog
MeshWeaver.Hosting.Monolith.Test.FileSystemStreamProviderTests ‑ GetStreamAsync_ExistingFile_ReturnsStream
MeshWeaver.Hosting.Monolith.Test.FileSystemStreamProviderTests ‑ GetStreamAsync_NonExistentFile_ReturnsNull
MeshWeaver.Hosting.Monolith.Test.FileSystemStreamProviderTests ‑ ProviderType_ReturnsFileSystem
MeshWeaver.Hosting.Monolith.Test.FileSystemStreamProviderTests ‑ WriteStreamAsync_CreatesDirectory
MeshWeaver.Hosting.Monolith.Test.FileSystemStreamProviderTests ‑ WriteStreamAsync_CreatesFile

MeshWeaver.AI.Test.ContentPluginTest ‑ GetFile_ExcelWithEmptyCellsAtStart_ShouldPreserveNulls
MeshWeaver.AI.Test.ContentPluginTest ‑ GetFile_ExcelWithNumberOfRows_ShouldLimitRows
MeshWeaver.AI.Test.ContentPluginTest ‑ GetFile_ExcelWithoutNumberOfRows_ShouldReadEntireFile
MeshWeaver.AI.Test.ContentPluginTest ‑ GetFile_NonExistentCollection_ShouldReturnErrorMessage
MeshWeaver.AI.Test.ContentPluginTest ‑ GetFile_NonExistentFile_ShouldReturnErrorMessage
MeshWeaver.AI.Test.ContentPluginTest ‑ GetFile_TextWithNumberOfRows_ShouldLimitRows
MeshWeaver.AI.Test.ContentPluginTest ‑ GetFile_TextWithoutNumberOfRows_ShouldReadEntireFile
MeshWeaver.Import.Test.CollectionPluginImportTest ‑ CollectionPlugin_Import_ShouldImportSuccessfully
MeshWeaver.Import.Test.CollectionPluginImportTest ‑ CollectionPlugin_Import_WithConfiguration_ShouldImportWithoutFormat
MeshWeaver.Import.Test.CollectionPluginImportTest ‑ CollectionPlugin_Import_WithCustomFormat_ShouldImportSuccessfully
…

♻️ This comment has been updated with latest results.

rbuergi added 21 commits October 29, 2025 19:44
@rbuergi
iterating on CollectionPlugin
6e3a343
@rbuergi
deferring messages until data context is initialized
cd648ff
@rbuergi
fixing nullability issues.
d7156d2
@rbuergi
consolidating CollectionPlugin and ContentCollectionPlugin into Conte…
364f54b 
…ntPlugin
@rbuergi
Treating callbacks as delivery finished
91c6708
@rbuergi
resolving deadlocks of content collection creation
481fd01
@rbuergi
excluding large properties from logging.
379736e
@rbuergi
improving ContentPlugin
56aaa04
@rbuergi
renaming config
97f5a21
@rbuergi
improving exception handling around messagehub start
14ff811
@rbuergi
making deferrables more robust
4f419fc
@rbuergi
rename GetFile => GetContent
f358ff6
@rbuergi
Refactoring deferrals.
f4e7d10
@rbuergi
updating deferral conditions
4d7f331
@rbuergi
fixing hub initialization
ca30dcb
@rbuergi
improving Initialization for importhub
52d8d03
@rbuergi
correcting startup mechanissm
80f4ea6
@rbuergi
fixing import unit test setup
b4a0b81
@rbuergi
undo appsettings
c46aa1f
@rbuergi
trying to make linking more robust
c19bf2e
@rbuergi
Moving all gate logic to MessageService
bcb25e2
Copy link

Copilot AI commented Nov 1, 2025

@rbuergi I've opened a new pull request, #63, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI mentioned this pull request Nov 1, 2025
Closed
rbuergi added 26 commits November 1, 2025 01:37
@rbuergi
fixing build error
b5d9ef8
@rbuergi
increasing timeouts
a1cdac5
@rbuergi
Improving threadsafety of MessageService
229a1ed
@rbuergi
introducing a test for pricing catalog.
089049d
@rbuergi
Correcting deferrals in MessageService
aafc7b8
@rbuergi
corercting locking in MessageService
2b09569
@rbuergi
avoid completing the deferral buffer.
696f684
@rbuergi
improving thread safety of MessageService
c72cb39
@rbuergi
trying not to duplicate routing path.
b8c81f5
@rbuergi
fixing message construction for callbacks
cf91a5a
@rbuergi
better treatment of deferred messages.
bf532b8
@rbuergi
placing locks outside removal of gate
4b015d7
@rbuergi
Revert "improving thread safety of MessageService"
3701c37 
This reverts commit c72cb39.

# Conflicts:
#	src/MeshWeaver.Messaging.Hub/MessageService.cs
@rbuergi
avoid duplicate messages
32161cf
@rbuergi
linking deferredBuffer to buffer rather than action block
c35171e
@rbuergi
removing UpdateStreamRequest from list of non-deferred messages
30df1a7
@rbuergi
eliminating delayedStart logic from layout areas
cd393da
@rbuergi
getting rid of blocking await in LayoutAreaHost
1611dc8
@rbuergi
improve logging
18033cc
@rbuergi
changing log level
eacd1d8
@rbuergi
missing .Synchronize in WorkspaceStreams
0df795a
@rbuergi
more fixes
322fbce
@rbuergi
fixing compilation
6d68462
@rbuergi
more .Synchronize()
35f8adb
@rbuergi
setting logging to Warning
2f67ded
@rbuergi
improving race conditions for closing activitieis
48e724a
@rbuergi rbuergi merged commit 721f258 into main Nov 3, 2025
2 checks passed
@rbuergi rbuergi deleted the import branch November 3, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rbuergi