Open
Conversation
added 2 commits
March 24, 2019 12:53
This reduces the scope of all the variables reducing the memory required by janino compiler
sumwale
approved these changes
Aug 14, 2019
sumwale
force-pushed
the
snappy/branch-2.1
branch
4 times, most recently
from
4ffe404 to
79ddd88
Compare
sumwale
force-pushed
the
snappy/branch-2.1
branch
2 times, most recently
from
52a9a47 to
763e1bb
Compare
sumwale
force-pushed
the
snappy/branch-2.1
branch
5 times, most recently
from
1456d1f to
3d73189
Compare
sumwale
force-pushed
the
snappy/branch-2.1
branch
6 times, most recently
from
1feaa36 to
cdd6d29
Compare
sumwale
force-pushed
the
snappy/branch-2.1
branch
3 times, most recently
from
cba053b to
3527357
Compare
sumwale
force-pushed
the
snappy/branch-2.1
branch
from
0169c3d to
1fb3673
Compare
sumwale
force-pushed
the
snappy/branch-2.1
branch
from
4a3161a to
efa4458
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Put the code of case block in {} to reduce the scope. This helps janino compiler reducing memory pressure.
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.