[SDENT 180] support for fail fast type casting#1542
Open
vatsalmevada wants to merge 9 commits intomasterfrom
Open
[SDENT 180] support for fail fast type casting#1542vatsalmevada wants to merge 9 commits intomasterfrom
vatsalmevada wants to merge 9 commits intomasterfrom
Conversation
added 3 commits
March 24, 2020 15:23
conversions based on configuration property `snappydata.failFastTypeCasting`.
instead of using generic RuntimeException - Adding tests for more scenarios
kneeraj
approved these changes
Mar 27, 2020
kneeraj
left a comment
kneeraj
left a comment
There was a problem hiding this comment.
Can you please add just one test for cluster and set the property on jdbc connection and check if all looks good.
Also why have you named in 'fail fast'? Just 'fail on cast error'. Curious?
Contributor
Author
@kneeraj To keep it shorter. Also it depicted the overall behaviour which is opposite of the existing "fail safe" behaviour. I am fine with "fail on cast error" too if "fail fast" sounds confusing. |
sumwale
force-pushed
the
master
branch
5 times, most recently
from
8b43301 to
2b254d9
Compare
sumwale
force-pushed
the
master
branch
5 times, most recently
from
2c254f0 to
0f2888f
Compare
sumwale
force-pushed
the
master
branch
2 times, most recently
from
a466d26 to
ea127bd
Compare
sumwale
force-pushed
the
master
branch
2 times, most recently
from
99ec79c to
c7b84fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Apache Spark handles type casting failures in a fail safe manner. Instead of
failing the entire query, Spark populates
nullvalues whenever type castingfailure occurs. Snappydata inherits the same behavior from Spark.
With this changes we are exposing a session level configuration to enable fail
fast behaviour for casting errors. i.e. instead of returning
nullvalues forcasting failures, the query will be failed altogether whenever first type cast
error occurs.
The configuration property is
snappydata.failOnCastErrorwhich defaultsto
false. Setting this property true will turn on fail fast casting behaviour.Note that these changes won't be available on smart connector mode as the
changes are done at the Spark layer.
Patch testing
Other PRs
TIBCOSoftware/snappy-spark#201