Skip to content

Conversation

@SeMuell
Copy link
Contributor

@SeMuell SeMuell commented Oct 16, 2025

Fixes #424

This PR introduces support for the latest MSTest version (4.0) to fix the file not found issue in #424.

Since the MSTestV2 package was also compatible with MSTestV3, I added another test project to have proper testing.

However, maybe there is a better, future-proof way for the implementation I haven't found yet in comparison to the naive approach, I'll keep digging.

Signed-off-by: SeMuell <s.mueller@gmx.org>
@SeMuell SeMuell force-pushed the feat/add_MSTestV4_support branch from 1fa509d to 84f4bc5 Compare October 16, 2025 17:08
@SeMuell
Copy link
Contributor Author

SeMuell commented Oct 17, 2025

Having a loosely coupled dependency like FluentAssertions to 'Microsoft.VisualStudio.TestTools.UnitTesting.AssertFailedException' with reflection would also work here. Doing this the direct dependency on the TestFramework could be removed and may be more future proof (maybe reasonable doing the same for the other projects). What do you think?

@@ -0,0 +1 @@
[assembly: DoNotParallelize]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-generated file... I do not see a need for this.

@alexanderlinne alexanderlinne added kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Nov 28, 2025
@mlautin
Copy link

mlautin commented Dec 9, 2025

Hey, please review and finish this PR. This prevents upgrade to the latest MSTest.SDK.

Co-authored-by: Alexander Linne <7416259+alexanderlinne@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.79%. Comparing base (4006980) to head (1f9054d).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
- Coverage   74.84%   73.79%   -1.06%     
==========================================
  Files         257      259       +2     
  Lines       17221    16387     -834     
  Branches     1575     1336     -239     
==========================================
- Hits        12889    12092     -797     
- Misses       3876     3878       +2     
+ Partials      456      417      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexanderlinne
Copy link
Collaborator

@SeMuell, I unfortunately was missing a setting to require sign-off on web-based commits. So you'd have to add a sign-off on the last commit manually. Also, please update your branch with main and make sure the formatting is correct. Then I'll be able to merge and release a new version

@SeMuell
Copy link
Contributor Author

SeMuell commented Dec 17, 2025

Unfortunately, I am currently on vacation without access to a laptop. However, I'll try to manage it in the next two days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MSTest 4 is not Supported

4 participants