-
Notifications
You must be signed in to change notification settings - Fork 73
Add MSTestV4 Support #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add MSTestV4 Support #426
Conversation
Signed-off-by: SeMuell <s.mueller@gmx.org>
1fa509d to
84f4bc5
Compare
|
Having a loosely coupled dependency like FluentAssertions to 'Microsoft.VisualStudio.TestTools.UnitTesting.AssertFailedException' with reflection would also work here. Doing this the direct dependency on the TestFramework could be removed and may be more future proof (maybe reasonable doing the same for the other projects). What do you think? |
| @@ -0,0 +1 @@ | |||
| [assembly: DoNotParallelize] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-generated file... I do not see a need for this.
|
Hey, please review and finish this PR. This prevents upgrade to the latest MSTest.SDK. |
Co-authored-by: Alexander Linne <7416259+alexanderlinne@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
- Coverage 74.84% 73.79% -1.06%
==========================================
Files 257 259 +2
Lines 17221 16387 -834
Branches 1575 1336 -239
==========================================
- Hits 12889 12092 -797
- Misses 3876 3878 +2
+ Partials 456 417 -39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@SeMuell, I unfortunately was missing a setting to require sign-off on web-based commits. So you'd have to add a sign-off on the last commit manually. Also, please update your branch with main and make sure the formatting is correct. Then I'll be able to merge and release a new version |
|
Unfortunately, I am currently on vacation without access to a laptop. However, I'll try to manage it in the next two days. |
Fixes #424
This PR introduces support for the latest MSTest version (4.0) to fix the file not found issue in #424.
Since the MSTestV2 package was also compatible with MSTestV3, I added another test project to have proper testing.
However, maybe there is a better, future-proof way for the implementation I haven't found yet in comparison to the naive approach, I'll keep digging.