Skip to content

Conversation

@alexanderlinne
Copy link
Collaborator

The ConditionManager now expects every condition to be an IOrderedCondition. This simplifies the implementation in the condition manager since it no longer has to differentiate between condition types.

To keep the current interface and fluent syntax implementation, ICondition now has a new extension method AsOrderedCondition, which wraps the given ICondition in a class that orders the results in the same order as the input elements. If the given ICondition already is an IOrderedCondition it is returned directly.

Signed-off-by: Alexander Linne <alexander.linne@tngtech.com>
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 76.58228% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.69%. Comparing base (c569fbb) to head (d026475).

Files with missing lines Patch % Lines
.../MethodMembers/MethodMemberConditionsDefinition.cs 57.14% 24 Missing ⚠️
.../Syntax/Elements/Types/TypeConditionsDefinition.cs 80.00% 9 Missing ⚠️
...chUnitNET/Fluent/Conditions/ConditionExtensions.cs 85.71% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
- Coverage   73.79%   73.69%   -0.10%     
==========================================
  Files         259      260       +1     
  Lines       16387    16465      +78     
  Branches     1336     1337       +1     
==========================================
+ Hits        12092    12134      +42     
- Misses       3878     3912      +34     
- Partials      417      419       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants