209. Minimum Size Subarray Sum #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryotaro25
reviewed
Jul 11, 2025
| - 空間計算量：O(1) | ||
|
|
||
| ```python | ||
| class Solution: |
Ryotaro25
reviewed
Jul 11, 2025
| - https://docs.python.org/ja/3.13/library/dis.html | ||
| - https://github.com/hayashi-ay/leetcode/pull/51 | ||
|
|
||
| 2分探索 |
There was a problem hiding this comment.
累積和を作った後は、自分は愚直に左から見ていきました。
2分探索の発想はなかったので勉強になります。
ryosuketc
reviewed
Jul 12, 2025
| ```python | ||
| class Solution: | ||
| def minSubArrayLen(self, target: int, nums: List[int]) -> int: | ||
| min_len = sys.maxsize |
There was a problem hiding this comment.
取りうる最大の値、という意味で sys.maxsize を使うべきかというかについては議論の余地があると思います。個人的にはここなら math.inf を使いたくなりますね。
このあたりの議論を想定しながら書いています。
huyfififi/coding-challenges#25 (comment)
tokuhirat/LeetCode#28 (comment)
tokuhirat/LeetCode#22 (comment)
Comment on lines
+24
to
+27
| if min_len == sys.maxsize: | ||
| return 0 | ||
| else: | ||
| return min_len |
There was a problem hiding this comment.
先に return しているので else 不要かと思います。
if min_len == sys.maxsize:
return 0
return min_len
hroc135
reviewed
Jul 20, 2025
| ```python | ||
| class Solution: | ||
| def minSubArrayLen(self, target: int, nums: List[int]) -> int: | ||
| left = 0 |
There was a problem hiding this comment.
nit: left, right はセットなのでループの真上の行で宣言したい気持ちになりました。
|
|
||
| prefix_sum = [0] * (len(nums) + 1) | ||
| for i in range(1, len(prefix_sum)): | ||
| prefix_sum[i] = prefix_sum[i - 1] + nums[i - 1] |
There was a problem hiding this comment.
この3行は prefix_sum = [0] + list(itertools.accumulate(nums)) と書くこともできるようです。
python なら一行で書けそうだなと思い、gemini に聞いてみました。
https://docs.python.org/3/library/itertools.html#itertools.accumulate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/minimum-size-subarray-sum/description/