fix: explicitly load docparams pylint plugin in .pylintrc#109
Conversation
The old plugin name seems to be `check_docs`, but that plugin does not seem to be available anymore.
kuanleetri
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @chrisochoatri and @tk-woven)
.pylintrc line 3 at r1 (raw file):
# Copyright 2019-2020 Toyota Research Institute. All rights reserved. [MAIN] load-plugins=pylint.extensions.docparams
Can we involve all the criteria under [MASTER]?
tk-woven
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @chrisochoatri and @kuanleetri)
.pylintrc line 3 at r1 (raw file):
Previously, kuanleetri (Kuan-Hui Lee) wrote…
Can we involve all the criteria under [MASTER]?
Unfortunately I don't think we can. The pylint docs ask us to use MAIN. I just tried putting this in MASTER locally, but then the unrecognized-option error is raised again.
wadimkehl
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @chrisochoatri and @kuanleetri)
.pylintrc line 3 at r1 (raw file):
Can we involve all the criteria under [MASTER]?
SGTM
tk-woven
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @chrisochoatri and @kuanleetri)
.pylintrc line 3 at r1 (raw file):
Previously, wadimkehl (Wadim Kehl) wrote…
Can we involve all the criteria under [MASTER]?
SGTM
After discussing review criteria with Kuan in a Slack DM, I'll dismiss this comment and proceed to merge to unblock the MRs stuck on this. As noted, I tested the recommendation for MASTER and had no luck unfortunately, but following the instruction of the docs I linked to did the trick.
Investigated suggestion but it unfortuantely did not fix the problem; need to merge this to unblock other MRs.
|
Thanks so much Tyler, much appreciated! |
Description
This is toward unblocking #101 which is stuck on a pylint configuration issue. We provide some configuration in
.pylintrcthat seems to expect thecheck_docsplugin, but the new plugin isdocparams. We therefore explicitly load thedocparamsplugin when running pylint.Reproduction
Before this change, run
in the root of the repo, and you'll see
After this change, the above example runs without errors.
This change is