Conversation
- Use CPM to fetch dftkit for converter functionality - Re-export converters from dftkit for backward compatibility - Update tests to use dftkit reference data - Remove Fortran language requirement (dmftproj now in dftkit) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove dmftproj Fortran component - Remove converter Python modules - Remove converter tests and test data These are now provided by the triqs_dftkit package. Co-Authored-By: Claude <noreply@anthropic.com>
the-hampel
approved these changes
Dec 22, 2025
Member
the-hampel
left a comment
the-hampel
left a comment
There was a problem hiding this comment.
Hi @Wentzell ,
I think this looks good to me. I tried both the new dftkit repo alone and this branch. I think the changes in the __init__.py module of the converters should make this fully backward compatible. I did not see any missing files or files that did not move. From my side this has green light to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This significantly reduces code duplication and centralizes converter maintenance in triqs_dftkit.
Test plan