Open
Conversation
Implemented basic mixin support in NodeImpl Implemented basic NamePathResolver and NamespaceRegistry support in SessionImpl Fixes #6
Member
Author
|
@hsfear @sagarsane Please review. |
There was a problem hiding this comment.
Minor : Could idx++ be in the for statement itself?
There was a problem hiding this comment.
I generally avoid style comments, but I will admit that even in Java, I would be include to use a list for newValues and convert back to an array at the end.
I will also note that you don't need idx here so you could probably use a foreach here with newIdx being a counter initialized before the loop begins.
That would also allow you to ditch the found flag, you can just compare newIdx to the size of the original array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented basic mixin support in NodeImpl
Implemented basic NamePathResolver and NamespaceRegistry support in SessionImpl
Fixes #6