-
Notifications
You must be signed in to change notification settings - Fork 9
Podspec from current repo #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hey, thanks for the credit. |
|
People seem not to be available. |
|
I've recompiled the lib and they're the results of it. |
|
I stumbled across a similar issue and fixed it (I think) by removing the NAChloride Pod that was still dangling around in my workspace/Project. I got duplicate libsodium binaries through that. |
|
Hi guys, First off, thanks for your contributions. I am not familiar enough with CocoaPods to accept these changes verbatim, but I see some things I think should be changed. Let's see if we can figure this out together. In the project, there are two top-level groups:
Also, no details of the underlying libsodium library should leak out. The intent is that the Objective-C wrapper fully encapsulates all of the implementation details of encrypting/decrypting/signing using idiomatic Objective-C constructs and naming schemes. Blindly exposing all headers violates my initial intent to keep these separate and that's probably the reason why the header includes need to be changed in this revision. I am opposed to changing that particular header because it is not intended to be exposed and it is copied directly from the libsodium project. Every time that library is rebuilt, the maintainer of SodiumObjc will need to copy that header and manipulate it in order to successfully integrate libsodium. The following headers are what I intended to be public:
I'm not sure how you'd specify this in the PodSpec, however. |
|
It'll be enough to adjust this line: https://github.com/iltercengiz/SodiumObjc/blob/master/SodiumObjc.podspec#L17 As |
Addresses #4
After posting my issue I saw that @iltercengiz has already forked this project here and created a podspec for it. He also fixed a resulting compiling problem (that comes from not including files as
"sodium/xyz.h"but as<sodium/xyz.h>). He also made some other changes I did not quite understand and don't think are necessary.I took your current repository, added his podspec and include fixes, and then changed his Podspec to point to TabbedOut's original repository and hope that this might be useful for someone. Installing SodiumObjc in my project was just adding
to the podfile for me and should work using your repository, once you decide to merge this in.
You should check whether the version "1.1" is correct.
Credit for this definitely should go to @iltercengiz.