-
Notifications
You must be signed in to change notification settings - Fork 13
feat: liquid staking module integration #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see you created a new init file, can we adjust init.sh instead and avoid having multiple init files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We made it to initialize multiply liquid validators in comparison to standard init. But i'm sure we could generalize original init script enough, if it's necessary. We will make this when upcoming dependency changes will be ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
|
could you please rename your PR to something more descriptive like feat: liquid staking |
utils/eth.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking about moving whole function to upgrade handler.
Integration of "x/liquidstake" module