added arbitratorAdded and arbitratorRemoved events #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xRomain
reviewed
Oct 16, 2023
contracts/TalentLayerPlatformID.sol
Outdated
| // Increment counter to start platform ids at index 1 | ||
| nextPlatformId.increment(); | ||
| mintStatus = MintStatus.ONLY_WHITELIST; | ||
| emit ArbitratorAdded(address(0), false); |
Contributor
There was a problem hiding this comment.
so this will not work as initialize will not be called after an upgrade, we need to create a new V2 here. Check doc https://docs.openzeppelin.com/contracts/4.x/api/proxy#Initializable
0xRomain
added
the
NEED FIX CODE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR:
Useful info
Auto-Review checklist
Typing
npm run lintnpm run format